adding recipe RemovedToolProviderConstructor

[ranuradh]

What's changed?

Created RemovedToolProviderConstructor Recipe:
For the following rule:

What's your motivation?

This recipe checks for a specific method pattern and converts it to a static call.The existing recipe ChangeMethodTargetToStatic did not work in this case since it doesn't meet the criteria of the method should not be static and should not be of the SameReceiverType

Anything in particular you'd like reviewers to focus on?

@cjobinabo

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[cjobinabo]

I don't think we need to look for all the methods this class contains. We know that every method within the class is static so this recipe just needs to check that the class invoking a method is of type javax.tools.ToolProvider

[ranuradh]

updated in next commit

[cjobinabo]

Several calls are made to method.getMethodType. We should go ahead and store the result of that call to a variable so we only invoke that method once.

[ranuradh]

updated in next commit

[cjobinabo]

We need to broaden this test case to capture more ways these calls can be make that better illustrate real world scenarios(for example take a look at how ToolProvider.getSystemJavaCompiler() is called here http://www.java2s.com/example/java-api/javax/tools/toolprovider/getsystemjavacompiler-0-8.html). I think some of the logic in your recipe can be stripped but we need better test coverage to confirm this.

[ranuradh]

added in the next commit

[timtebeek]

Super seeded by

• Recipe to call ToolProvider methods as static methods, not on instances #477