Improve handling of interfaces in LombokValueToRecord #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgpar
force-pushed
the
dontConvertClassesThatImplementInterfaces
branch
from
d0321f0 to
84b7b1f
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
holgpar
force-pushed
the
dontConvertClassesThatImplementInterfaces
branch
from
84b7b1f to
73a3101
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
holgpar
commented
Apr 3, 2024
| && !J.ClassDeclaration.Kind.Type.Record.equals(classDeclaration.getKind()) | ||
| && classDeclaration.getAllAnnotations().stream() | ||
| .allMatch(ann -> LOMBOK_VALUE_MATCHER.matches(ann) && (ann.getArguments() == null || ann.getArguments().isEmpty())) | ||
| && !allAnnotations.isEmpty() |
There was a problem hiding this comment.
This is necessary because allMatch will return true on an empty set. The recipe would then convert an empty interface to a record. Not sure why that did not cause issue before.
this also considers methods inherited by super-interfaces.
holgpar
force-pushed
the
dontConvertClassesThatImplementInterfaces
branch
from
73a3101 to
c5e8a58
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Before, no conversion was done when any interface was implemented.
Now, it is checked that the interface declares a method which would "conflict" with the conversion.
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@knutwannheden
Have you considered any alternatives or workarounds?
Any additional context
Checklist