Remove Temporal annotation from attributes to avoid EclipseLink error

[evie-lau]

What's changed?

OpenJPA -> EclipseLink recipe to remove @Temporal annotation on attributes where data does not need to be converted.

What's your motivation?

https://wiki.eclipse.org/EclipseLink/Examples/JPA/Migration/OpenJPA/Mappings#.40Temporal_on_java.sql.Date.2FTime.2FTimestamp_fields

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[cjobinabo]

Can you port over the following fields:

• TemporalType.TIMESTAMP used with java.sql.Date
• TemporalType.DATE used with java.sql.Timestamp
• TemporalType.TIME used with java.sql.Timestamp

[cjobinabo]

Actually I think the help we have for this issue is incorrect. It sounds like this recipes only needs to remove annotation for the following combinations:

• TemporalType.TIMESTAMP and java.sql.Timestamp
• TemporalType.DATE and java.sql.Date
• TemporalType.TIME and java.sql.Time

[evie-lau]

I did notice the rule is overly broad, but the other cases that we remove the annotation would have been an invalid combination in either OpenJPA or EclipseLink anyway. So it would just fix the code error.

[evie-lau]

For clarity, the current implementation handles/fixes all the cases except the ones that require a converter.
Do we want to include the converter in this recipe?

[cjobinabo]

Let's not worry about the converter for now. But I'll create an issue to look into it later.

[cjobinabo]

It probably makes sense to have a test that uses Date, Time, and Timestamp classes from other packages such as java.util.Date, java.security.Timestamp, org.omg.Security.Time to make it clear those are valid cases

[evie-lau]

From the Eclipse page, I only see that java.util.Date and java.util.Calendar are allowed. I added a test case with these to show no change occurs.

[cjobinabo]

Yeah the idea behind the tests using Date, Time, and Timestamp classes from other packages was to make it clear the recipe should only apply to java.sql.Date, java.sql.Timestamp, java.sql.Time. I see I had a typo in my original comment.

Update:
It looks like your allowTemporalOnValidClasses test covers this