Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDI recipe #340
CDI recipe #340
Changes from 2 commits
ac34dd2
6c5e0cd
48061f9
e1072c8
730d337
954f8b6
b624d7c
92bbacf
7ba16f4
cbfe7e7
19bce8b
1a5524b
359f7b2
e185033
fdd6b2c
87ef9a2
7ac0ae1
3b93dfd
48914e8
4448fe4
bce6039
4cccdbf
ddd40a4
fbc45b9
9e26317
41e54de
e8f44e7
360b481
2938411
1da61b2
701fb68
69b6659
64fb591
f3f82f9
83b6afa
701e46b
a466098
65f1728
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UpdateAddAnnotatedType
is only used once, yet the implementation seems to switch between two types of method patterns. Should it be used once more? Or can we simplify the implementation to only support a single case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timtebeek I added the javax case as well .Should be there in the final commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than one big test to verify three different Java recipes, as well as some yaml configuration, I'd prefer to see a unit test class per Java recipe; That helps make it clear what each recipe contributes, and allows one to jump from the implementation directly to the associated tests rather than having to deduce that from usage in yaml files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timtebeek will do that from the next recipe. This one just would up like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getInjectionTargetFactory
needs to take in theannotatedType
which was previous passed tocreateInjectionTarget
createInjectionTarget
would take in null. Here are some examples I've seen of this code being used https://www.tabnine.com/code/java/methods/javax.enterprise.inject.spi.BeanManager/getInjectionTargetFactoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldnt get this to work as well since if the arguments are right I was using the simpleName change and that worked..now we need to add different arguments to the methods as well. I updated the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I'll look into both updates