RemovalsServletJakarta10 Recipe

src/main/java/org/openrewrite/java/migrate/jakarta/GetRealPathUpdate.java → src/main/java/org/openrewrite/java/migrate/jakarta/UpdateGetRealPath.java

@@ -18,38 +18,36 @@
 
 import lombok.EqualsAndHashCode;
 import lombok.Value;
-import org.jetbrains.annotations.NotNull;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Option;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.internal.lang.NonNull;
-import org.openrewrite.internal.lang.Nullable;
 import org.openrewrite.java.JavaVisitor;
 import org.openrewrite.java.MethodMatcher;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.JavaType;
 
 @Value
 @EqualsAndHashCode(callSuper = false)
-public class GetRealPathUpdate extends Recipe {
+public class UpdateGetRealPath extends Recipe {
     @Option(displayName = "Method Pattern",
             description = "A `jakarta.servlet.ServletRequest` or `jakarta.servlet.ServletRequestWrapper getRealPath(String)` matching required",
             example = "jakarta.servlet.ServletRequest getRealPath(String)")
     @NonNull String methodPattern;
 
     @Override
-    public @NotNull String getDisplayName() {
-        return "Remove methods calls";
+    public String getDisplayName() {
+        return "Updates getRealPath() to call getContext() followed by getRealPath()";
     }
 
     @Override
-    public @NotNull String getDescription() {
-        return "Updates `getRealPath()` for `jakarta.servlet.ServletRequest` and `jakarta.servlet.ServletRequestWrapper`";
+    public String getDescription() {
+        return "Updates `getRealPath()` for `jakarta.servlet.ServletRequest` and `jakarta.servlet.ServletRequestWrapper` to use `ServletContext.getRealPath(String)`";
     }
 
     @Override
-    public @NotNull TreeVisitor<?, ExecutionContext> getVisitor() {
+    public TreeVisitor<?, ExecutionContext> getVisitor() {
         return new MethodInvocationVisitor(methodPattern);
     }
 
@@ -60,7 +58,6 @@ private MethodInvocationVisitor(String methodPattern) {
             METHOD_PATTERN = new MethodMatcher(methodPattern, false);
         }
 
-        @Nullable
         @Override
         public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ec) {
             if (METHOD_PATTERN.matches(method)) {

src/main/resources/META-INF/rewrite/jakarta-ee-10.yml

@@ -342,9 +342,9 @@ recipeList:
       oldParameterNames: [ str, ex ]
       ignoreDefinition: true
       matchOverrides: true
-  - org.openrewrite.java.migrate.jakarta.GetRealPathUpdate:
+  - org.openrewrite.java.migrate.jakarta.UpdateGetRealPath:
       methodPattern: jakarta.servlet.ServletRequest getRealPath(String)
-  - org.openrewrite.java.migrate.jakarta.GetRealPathUpdate:
+  - org.openrewrite.java.migrate.jakarta.UpdateGetRealPath:
       methodPattern: jakarta.servlet.ServletRequestWrapper getRealPath(String)
   - org.openrewrite.java.DeleteMethodArgument:
       methodPattern: jakarta.servlet.UnavailableException <constructor>(jakarta.servlet.Servlet, String)