Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add recipes to migrate boxed primitive constructors deprecate… #333

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

dsibilio
Copy link
Contributor

…d in Java 9 (#332)"

This reverts commit 59f1bb5.

What's your motivation?

While dealing with the new Float(double) edge case I actually found out there already was an OpenRewrite recipe in the Java 8 to 11 flow to deal with these deprecated constructors! lol
This makes the new implementation with Refaster unnecessary in the first place.
It was hidden in a separate project which is why I didn't find it at first: https://github.com/openrewrite/rewrite-static-analysis/blob/main/src/main/java/org/openrewrite/staticanalysis/PrimitiveWrapperClassConstructorToValueOf.java & https://github.com/openrewrite/rewrite-migrate-java/blob/main/src/main/resources/META-INF/rewrite/java-version-11.yml#L40.

@timtebeek at least it was good practice and it was a good opportunity for me to familiarize with Refaster, thanks!

@timtebeek
Copy link
Contributor

Appreciate the discipline to then revert your own change again! I mist say I slightly prefer the Refaster recipe approach; it's clear and easy to maintain. But that's not enough to maintain two copies, or ask folks to switch between implementations. Thanks again for putting the effort in; when searching earlier I had searched for Integer, and then the other recipe implementation did not pop up. :/

@timtebeek timtebeek merged commit 0131b63 into openrewrite:main Oct 28, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants