Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipe RemovedStateManagerMethods in jakarta-ee-10 #314

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Recipe RemovedStateManagerMethods in jakarta-ee-10 #314

merged 8 commits into from
Oct 11, 2023

Conversation

ranuradh
Copy link
Contributor

@ranuradh ranuradh commented Oct 6, 2023 •
edited
Loading

What's changed?

image

Anyone you would like to review specifically?

@joanvr

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

@ranuradh ranuradh changed the title Recipe removed state manager methods Recipe removed state manager methods in jakarta-ee-10 Oct 6, 2023
@ranuradh ranuradh changed the title Recipe removed state manager methods in jakarta-ee-10 Recipe RemovedStateManagerMethods in jakarta-ee-10 Oct 6, 2023
@ranuradh ranuradh self-assigned this Oct 6, 2023
@ranuradh ranuradh requested a review from joanvr October 6, 2023 16:02
@cjobinabo
Copy link
Contributor

Thanks for making the updates!

@timtebeek timtebeek added the recipe Recipe requested label Oct 11, 2023
@timtebeek
Copy link
Contributor

Thanks for the new recipes and follow up on the feedback received!

@ranuradh
Copy link
Contributor Author

@timtebeek could you merge it? Thanks!

@timtebeek timtebeek merged commit 0346afa into openrewrite:main Oct 11, 2023
1 check passed
@timtebeek
Copy link
Contributor

@timtebeek could you merge it? Thanks!

Yes thanks, merged just now; was waiting for the tests to complete, since we don't have auto merge enabled here.

@ranuradh ranuradh deleted the recipe_RemovedStateManagerMethods branch October 11, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjobinabo cjobinabo cjobinabo approved these changes

@timtebeek timtebeek timtebeek approved these changes

@joanvr joanvr joanvr approved these changes

Assignees

@ranuradh ranuradh

Labels
recipe Recipe requested
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ranuradh @cjobinabo @timtebeek @joanvr @AnuRam123