Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default plain text mask to include .config and markdown files #624

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

jonesbusy
Copy link
Contributor

@jonesbusy jonesbusy commented Sep 9, 2023

What's changed?

The default list of plain text mask

What's your motivation?

Rewriting mardown files and .config extension (for example .mvn/maven.config or .mvn/jvm.config)

Have you considered any alternatives or workarounds?

Directly override the plainTextMasks on the plugin config. But I think having those default is a valid use case.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files
  • I've updated the documentation (if applicable)

Doc is : openrewrite/rewrite-docs#231

Also the list was not up-to-date

@timtebeek timtebeek merged commit 18333ad into openrewrite:main Sep 11, 2023
@jonesbusy jonesbusy deleted the feature/markdown-as-textfile branch September 11, 2023 08:46
@timtebeek
Copy link
Contributor

Thanks for the suggestion! Should become available in the next release. You can try this out through our latest snapshots once we resolve the build issues on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants