Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spring-security-web parser classpath dependency #148

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

bryceatmoderne
Copy link
Contributor

What's changed?

To address the following observed in customer tenants:

org.openrewrite.internal.RecipeRunException: java.lang.IllegalArgumentException: Unable to find classpath resource dependencies beginning with: 'spring-security-web'.
The caller is of type org.openrewrite.java.security.spring.CsrfProtection$1.

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Why this change wasn't previously necessary?

Anyone you would like to review specifically?

@sambsnyd @timtebeek

Have you considered any alternatives or workarounds?

No

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@bryceatmoderne bryceatmoderne self-assigned this Dec 11, 2024
@timtebeek timtebeek added the bug Something isn't working label Dec 11, 2024
@timtebeek
Copy link
Contributor

This was missing, and somehow we do not throw an exception when those can not be found, despite this code. I saw the same the other day with a missing dependency in tests. Quite annoying as it leads to silent failures.

@bryceatmoderne bryceatmoderne merged commit 80498ce into main Dec 11, 2024
2 checks passed
@bryceatmoderne bryceatmoderne deleted the add-spring-security-web-parser-classpath-dep branch December 11, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants