doc: suggest disabling GPG signed commits to allow build to pass #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions to disable signed commits in the rewrite repository if necessary because JGit does not currently have support for SSH format GPG signatures.
What's changed?
Added a suggestion to the "building from source" page to disable GPG signed commits in the repo, in case you are using SSH format GPG signed commits globally, which JGit does not currently support.
What's your motivation?
Make it easier for people to build OpenRewrite from source without running into mysterious test errors related to their git configuration.
Errors during
./gradlew build
look like this when SSH GPG commit signing is configured:Anything in particular you'd like reviewers to focus on?
Not really, this is a single-line documentation update.
Anyone you would like to review specifically?
No.
Have you considered any alternatives or workarounds?
Yes, disable GPG signed commits globally, but this may not be an option or the most convenient option for most people because they would like to sign their commits elsewhere.
I looked into upgrading JGit but not even
master
supports the SSH format. See GpgConfig.java for more information, or this bug.Any additional context
Checklist
I've added unit tests to cover both positive and negative casesN/AI've added the license header to any new files throughN/A, no new files./gradlew licenseFormat
I've used the IntelliJ IDEA auto-formatter on affected filesN/A