Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARR: Add secondary reviewer field to official review form #2409

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ARR: Add secondary reviewer field to official review form #2409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7dac3a
Add new field
haroldrubio Oct 27, 2024
f60ad82
Check field readers
haroldrubio Oct 29, 2024
90b10ca
Add signature to readers
haroldrubio Oct 29, 2024
51a1211
Check for PCs instead of venue
haroldrubio Oct 31, 2024
9fb7649
Merge branch 'master' into feature/arr-secondary-rev
haroldrubio Dec 9, 2024
364020e
Merge branch 'master' into feature/arr-secondary-rev
haroldrubio Jan 10, 2025
b0c70fa
Merge branch 'master' into feature/arr-secondary-rev
haroldrubio Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions openreview/arr/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,6 +1201,16 @@ class Participants(Enum):
'Blind_Submission_License_Agreement': 'Submission_Revision_Stage'
}
FIELD_READERS = {
'Official_Review': {
'content_name': 'additional_review_form_options',
'fields': {
'secondary_reviewer': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED,
Participants.SIGNATURE
]
}
},
'Meta_Review': {
'content_name': 'additional_meta_review_form_options',
'fields': {
Expand Down
11 changes: 11 additions & 0 deletions openreview/stages/arr_content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1495,6 +1495,17 @@
"input": "checkbox"
}
}
},
"secondary_reviewer": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the secondary reviewer always an openreview user?

"value": {
"param": {
"type": "profile[]",
"regex": "^~\\S+$|([a-z0-9_\\-\\.]{1,}@[a-z0-9_\\-\\.]{2,}\\.[a-z]{2,},){0,}([a-z0-9_\\-\\.]{1,}@[a-z0-9_\\-\\.]{2,}\\.[a-z]{2,})",
"optional": True
}
},
"description": "If another person contributed significantly to this review, please indicate their OpenReview profile ID here. If they do not have a profile, please ask them to create one. Note that only EICs, SAEs, and AEs can see this field - other reviewers cannot. (optional)",
"order": 24
}
}

Expand Down
22 changes: 17 additions & 5 deletions tests/test_arr_venue_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2919,7 +2919,8 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "Yes"}
"reviewer_certification": {"value": "Yes"},
"secondary_reviewer": {"value": ["~Reviewer_ARRTwo1"]}
}
)
)
Expand All @@ -2945,7 +2946,8 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "Yes"}
"reviewer_certification": {"value": "Yes"},
"secondary_reviewer": {"value": ["~Reviewer_ARRTwo1"]}
}
)
)
Expand Down Expand Up @@ -2978,7 +2980,8 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "Yes"}
"reviewer_certification": {"value": "Yes"},
"secondary_reviewer": {"value": ["~Reviewer_ARRTwo1"]}
}
)
)
Expand Down Expand Up @@ -3007,7 +3010,8 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "Yes"}
"reviewer_certification": {"value": "Yes"},
"secondary_reviewer": {"value": ["~Reviewer_ARRTwo1"]}
}
)
)
Expand Down Expand Up @@ -3923,7 +3927,8 @@ def generate_official_review_content(tested_field=None):
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "Yes"}
"reviewer_certification": {"value": "Yes"},
"secondary_reviewer": {"value": ["~Reviewer_ARRTwo1"]}
}
ret_content['ethical_concerns'] = {'value': 'There are no concerns with this submission'}

Expand Down Expand Up @@ -3963,6 +3968,13 @@ def generate_official_review_content(tested_field=None):

review = pc_client_v2.get_note(id=rev_edit['note']['id'])
assert 'readers' not in review.content['reviewer_certification']
assert 'readers' in review.content['secondary_reviewer']
assert review.content['secondary_reviewer']['readers'] == [
'aclweb.org/ACL/ARR/2023/August/Program_Chairs',
'aclweb.org/ACL/ARR/2023/August/Submission3/Senior_Area_Chairs',
'aclweb.org/ACL/ARR/2023/August/Submission3/Area_Chairs',
user
]

return rev_edit, pc_client_v2.get_note(test_submission.id)

Expand Down