ARR: Fix assignment quotas #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a request to be able to increase the quota for some papers where the reviews may have been AI generated and need extra reviewers - I'm thinking of a way to properly implement this |
|
I'll work on a separate request for the new issue I made here #2450, for now we can start with just the fix. |
celestemartinez
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where, if the 3rd edge (out of the Assignment + Invite_Assignment edges) posted to a paper is an Invite_Assignment edge, the process function fails because the pre-process saw it as posting a 4th edge.
The pre-process functions are changed to exclude the posted edge from the edge count if there is already an edge with that ID.
To allow the Assignment_Recruitment process function to complete, only non-accepted and non-declined Invite_Assignment edges are counted. The logic is still preserved because if an Invite_Assignment edge is accepted, then there must be an Assignment edge which are counted