increase package version (#2204)

* increase package version * add signatures to be readers of the hidden field * pass only values --------- Co-authored-by: Melisa Bok <[email protected]>
openreview · Jun 18, 2024 · b855dfa · b855dfa
1 parent 1743ff1
commit b855dfa
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/openreview/arr/helpers.py b/openreview/arr/helpers.py
@@ -1162,6 +1162,7 @@ class Participants(Enum):
         AUTHORS = 9
         ETHICS_CHAIRS = 10
         ETHICS_REVIEWERS_ASSIGNED = 11
+        SIGNATURE = 12
 
     SUPPORTED_STAGES = {
         'Official_Review': 'Review_Stage',
@@ -1176,7 +1177,8 @@ class Participants(Enum):
             'fields': {
                 'reviewer_certification': [
                     Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
-                    Participants.AREA_CHAIRS_ASSIGNED
+                    Participants.AREA_CHAIRS_ASSIGNED,
+                    Participants.SIGNATURE
                 ]
             }
         }
@@ -1268,6 +1270,9 @@ def _set_field_readers(self, venue):
                     if ARRStage.Participants.ETHICS_REVIEWERS_ASSIGNED in readers:
                         field_readers.append(venue.get_ethics_reviewers_id('${7/content/noteNumber/value}'))
 
+                    if ARRStage.Participants.SIGNATURE in readers:
+                        field_readers.append('${4/signatures}')
+
                     print(f"setting readers for {content_name}/{field_name} in {self.super_invitation_id}")
                     if self.type == ARRStage.Type.STAGE_NOTE:
                         self.stage_arguments['content'][content_name][field_name]['readers'] = field_readers

diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 setup(
     name='openreview-py',
 
-    version='1.40.0',
+    version='1.40.1',
 
     description='OpenReview API Python client library',
     url='https://github.com/openreview/openreview-py',

diff --git a/tests/test_arr_venue_v2.py b/tests/test_arr_venue_v2.py
@@ -3306,7 +3306,9 @@ def generate_official_review_content(tested_field=None):
             if not existing_note:
                 content = generate_official_review_content(tested_field=tested_field)
             if existing_note:
-                content = existing_note['content']
+                content = {}
+                for key, value in existing_note['content'].items():
+                    content[key] = { 'value': value['value'] }
                 if tested_field:
                     content[tested_field] = {'value':'Yes'}
                     content['ethical_concerns'] = {'value': 'There are concerns with this submission'}
@@ -3334,6 +3336,7 @@ def generate_official_review_content(tested_field=None):
                 'aclweb.org/ACL/ARR/2023/August/Program_Chairs',
                 f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Senior_Area_Chairs",
                 f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Area_Chairs",
+                review.signatures[0]
             } 
 
             return rev_edit, pc_client_v2.get_note(test_submission.id)
@@ -3451,6 +3454,7 @@ def now():
             'aclweb.org/ACL/ARR/2023/August/Program_Chairs',
             f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Senior_Area_Chairs",
             f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Area_Chairs",
+            review.signatures[0]
         } 
 
         # Edit with ethics flag to double check that authors are present