Meta Review SAC Revision: Use acronym of SAC name in invitation id (#…

…2351) * Use acronym of SAC name in SAC revision invitation id * Increase package version to 1.43.4
openreview · Sep 19, 2024 · ac4c826 · ac4c826
1 parent 5aa0341
commit ac4c826
Show file tree

Hide file tree

Showing 3 changed files with 129 additions and 3 deletions.
diff --git a/openreview/venue/invitation.py b/openreview/venue/invitation.py
@@ -992,8 +992,10 @@ def set_meta_review_invitation(self):
         self.save_invitation(invitation, replacement=False)
 
         if self.venue.use_senior_area_chairs:
+            # Build SAC acronym
+            sac_acronym = ''.join([s[0].upper() for s in self.venue.senior_area_chairs_name.split('_')])
 
-            meta_review_sac_edit_invitation_id = self.venue.get_invitation_id(meta_review_stage.name + '_SAC_Revision')
+            meta_review_sac_edit_invitation_id = self.venue.get_invitation_id(meta_review_stage.name + f'_{sac_acronym}_Revision')
             invitation = Invitation(id=meta_review_sac_edit_invitation_id,
                 invitees=[venue_id],
                 readers=[venue_id],
@@ -1028,7 +1030,7 @@ def set_meta_review_invitation(self):
                     },
                     'replacement': True,
                     'invitation': {
-                        'id': self.venue.get_invitation_id(meta_review_stage.child_invitations_name + '_SAC_Revision', '${2/content/noteNumber/value}'),
+                        'id': self.venue.get_invitation_id(meta_review_stage.child_invitations_name + f'_{sac_acronym}_Revision', '${2/content/noteNumber/value}'),
                         'signatures': [ venue_id ],
                         'readers': ['everyone'],
                         'writers': [venue_id],

diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 setup(
     name='openreview-py',
 
-    version='1.43.3',
+    version='1.43.4',
 
     description='OpenReview API Python client library',
     url='https://github.com/openreview/openreview-py',

diff --git a/tests/test_aaai_conference.py b/tests/test_aaai_conference.py
@@ -880,6 +880,130 @@ def test_release_reviews(self, client, openreview_client, helpers, selenium, req
         review_note = openreview_client.get_notes(invitation='AAAI.org/2025/Conference/Submission1/-/Second_Round_Review', sort='number:asc')[0]
         assert 'AAAI.org/2025/Conference/Submission1/Authors' in review_note.readers
 
+    def test_meta_review_stage(self, client, openreview_client, helpers, selenium, request_page):
+        pc_client=openreview.Client(username='[email protected]', password=helpers.strong_password)
+        request_form=pc_client.get_notes(invitation='openreview.net/Support/-/Request_Form')[0]
+
+        now = datetime.datetime.utcnow()
+        start_date = now - datetime.timedelta(days=2)
+        due_date = now + datetime.timedelta(days=3)
+
+        # Open Phase 1 meta review stage
+        pc_client.post_note(openreview.Note(
+            content= {
+                'make_meta_reviews_public': 'No, meta reviews should NOT be revealed publicly when they are posted',
+                'meta_review_start_date': start_date.strftime('%Y/%m/%d'),
+                'meta_review_deadline': due_date.strftime('%Y/%m/%d'),
+                'release_meta_reviews_to_authors': 'No, meta reviews should NOT be revealed when they are posted to the paper\'s authors',
+                'release_meta_reviews_to_reviewers': 'Meta review should not be revealed to any reviewer',
+                'additional_meta_review_form_options': {
+                    "recommendation": {
+                        "order": 2,
+                        "value": {
+                            "param": {
+                                "type": "string",
+                                "input": "radio",
+                                "enum": [
+                                    "Reject",
+                                    "Proceed to Phase 2"
+                                ]
+                            }
+                        }
+                    }
+                }
+            },
+            forum= request_form.id,
+            invitation= f'openreview.net/Support/-/Request{request_form.number}/Meta_Review_Stage',
+            readers= ['AAAI.org/2025/Conference/Program_Chairs', 'openreview.net/Support'],
+            referent= request_form.id,
+            replyto= request_form.id,
+            signatures= ['~Program_AAAIChair1'],
+            writers= [],
+        ))
+        helpers.await_queue()
+
+        invitations = openreview_client.get_invitations(invitation='AAAI.org/2025/Conference/-/Meta_Review')
+        assert len(invitations) == 9
+        assert invitations[0].edit['note']['id']['param']['withInvitation'] == invitations[0].id
+
+        invitations = openreview_client.get_invitations(invitation='AAAI.org/2025/Conference/-/Meta_Review_AC_Revision')
+        assert len(invitations) == 9
+
+        sac_revision_invitation = openreview_client.get_invitation('AAAI.org/2025/Conference/Submission1/-/Meta_Review_AC_Revision')
+        invitation = openreview_client.get_invitation('AAAI.org/2025/Conference/Submission1/-/Meta_Review')
+        assert sac_revision_invitation.edit['note']['id']['param']['withInvitation'] == invitation.id
+
+        # Post meta review
+        ac_client = openreview.api.OpenReviewClient(username = '[email protected]', password=helpers.strong_password)
+        anon_id = ac_client.get_groups(prefix=f'AAAI.org/2025/Conference/Submission1/Senior_Program_Committee_', signatory='[email protected]')[0].id
+
+        meta_review = ac_client.post_note_edit(
+            invitation='AAAI.org/2025/Conference/Submission1/-/Meta_Review',
+            signatures=[anon_id],
+            note=openreview.api.Note(
+                content = {
+                    'metareview': { 'value': 'This is a meta review' },
+                    'recommendation': { 'value': 'Reject' },
+                    'confidence': { 'value': 5 },
+                }
+            )
+        )
+        helpers.await_queue_edit(openreview_client, edit_id=meta_review['id'])
+
+        # Post meta review SAC revision to change recommendation
+        sac_client = openreview.api.OpenReviewClient(username='[email protected]', password=helpers.strong_password)
+        meta_review = sac_client.get_notes(invitation='AAAI.org/2025/Conference/Submission1/-/Meta_Review')[0]
+        sac_client.post_note_edit(
+            invitation='AAAI.org/2025/Conference/Submission1/-/Meta_Review_AC_Revision',
+            signatures=['AAAI.org/2025/Conference/Submission1/Area_Chairs'],
+            note=openreview.api.Note(
+                id=meta_review.id,
+                content = {
+                    'metareview': { 'value': 'This is a meta review - AC revision' },
+                    'recommendation': { 'value': 'Proceed to Phase 2' },
+                    'confidence': { 'value': 5 },
+                }
+            )
+        )
+
+        # Close meta review stage
+        now = datetime.datetime.utcnow()
+        start_date = now - datetime.timedelta(days=2)
+        due_date = now - datetime.timedelta(days=1)
+
+        pc_client.post_note(openreview.Note(
+            content= {
+                'make_meta_reviews_public': 'No, meta reviews should NOT be revealed publicly when they are posted',
+                'meta_review_start_date': start_date.strftime('%Y/%m/%d'),
+                'meta_review_deadline': due_date.strftime('%Y/%m/%d'),
+                'release_meta_reviews_to_authors': 'No, meta reviews should NOT be revealed when they are posted to the paper\'s authors',
+                'release_meta_reviews_to_reviewers': 'Meta review should not be revealed to any reviewer',
+                'additional_meta_review_form_options': {
+                    "recommendation": {
+                        "order": 2,
+                        "value": {
+                            "param": {
+                                "type": "string",
+                                "input": "radio",
+                                "enum": [
+                                    "Reject",
+                                    "Proceed to Phase 2"
+                                ]
+                            }
+                        }
+                    }
+                }
+            },
+            forum= request_form.id,
+            invitation= f'openreview.net/Support/-/Request{request_form.number}/Meta_Review_Stage',
+            readers= ['AAAI.org/2025/Conference/Program_Chairs', 'openreview.net/Support'],
+            referent= request_form.id,
+            replyto= request_form.id,
+            signatures= ['~Program_AAAIChair1'],
+            writers= [],
+        ))
+        helpers.await_queue()
+
     def test_comment_emails(self, client, openreview_client, helpers, request_page, selenium):
         pc_client=openreview.Client(username='[email protected]', password=helpers.strong_password)
         request_form=pc_client.get_notes(invitation='openreview.net/Support/-/Request_Form')[0]