Skip to content

Commit

Permalink
Fix/ Revision Invitation: make visible to venue and paper authors only (
Browse files Browse the repository at this point in the history
#1868)

* make revision inv visible to venue and paper authors

* increase package version
  • Loading branch information
celestemartinez authored Oct 16, 2023
1 parent c3b33c8 commit a96fa05
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion openreview/venue/invitation.py
Original file line number Diff line number Diff line change
Expand Up @@ -1949,7 +1949,7 @@ def set_submission_revision_invitation(self, submission_revision_stage=None):
'invitation': {
'id': self.venue.get_invitation_id(revision_stage.name, '${2/content/noteNumber/value}'),
'signatures': [venue_id],
'readers': ['everyone'],
'readers': [venue_id, self.venue.get_authors_id(number='${3/content/noteNumber/value}')],
'writers': [venue_id],
'invitees': [venue_id, self.venue.get_authors_id(number='${3/content/noteNumber/value}')],
'cdate': revision_cdate,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
setup(
name='openreview-py',

version='1.31.1',
version='1.32.0',

description='OpenReview API Python client library',
url='https://github.com/openreview/openreview-py',
Expand Down
4 changes: 3 additions & 1 deletion tests/test_neurips_conference_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,9 @@ def test_submit_papers(self, test_client, client, helpers, openreview_client):

assert test_client.get_invitation('NeurIPS.cc/2023/Conference/Submission5/-/Withdrawal')
assert test_client.get_invitation('NeurIPS.cc/2023/Conference/Submission5/-/Desk_Rejection')
assert test_client.get_invitation('NeurIPS.cc/2023/Conference/Submission5/-/Revision')
revision_inv = test_client.get_invitation('NeurIPS.cc/2023/Conference/Submission5/-/Revision')
assert revision_inv
assert ['NeurIPS.cc/2023/Conference', 'NeurIPS.cc/2023/Conference/Submission5/Authors'] == revision_inv.readers

post_submission = openreview_client.get_invitation('NeurIPS.cc/2023/Conference/-/Post_Submission')
assert 'authors' in post_submission.edit['note']['content']
Expand Down

0 comments on commit a96fa05

Please sign in to comment.