update error throw logic

openreview · Sep 30, 2024 · 34c74be · 34c74be
1 parent d231bf6
commit 34c74be
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/packages/client/src/tools.js b/packages/client/src/tools.js
@@ -869,26 +869,28 @@ export default class Tools {
   static async extractAbstract(url) {
     const metaExtractionUrl = 'https://meta-extraction-wivlbyt6ga-uc.a.run.app/metadata';
     const queryString = generateQueryString({ url });
+    let result;
+
     try {
-      const result = await fetch(`${metaExtractionUrl}?${queryString}`, {
+      result = await fetch(`${metaExtractionUrl}?${queryString}`, {
         method: 'GET',
       });
-
-      if (result.status === 200) {
-        return result.json();
-      }
-
-      const contentType = result.headers.get('content-type');
-      throw new OpenReviewError({
-        name: 'ExtractAbstractError',
-        message: (contentType && contentType.indexOf('application/json') !== -1) ? JSON.stringify(await result.json()) : await result.text(),
-        status: result.status || 500
-      });
     } catch (error) {
       throw new OpenReviewError({
         name: 'ExtractAbstractError',
         message: error,
       });
     }
+
+    if (result.status === 200) {
+      return result.json();
+    }
+
+    const contentType = result.headers.get('content-type');
+    throw new OpenReviewError({
+      name: 'ExtractAbstractError',
+      message: (contentType && contentType.indexOf('application/json') !== -1) ? JSON.stringify(await result.json()) : await result.text(),
+      status: result.status || 500
+    });
   }
 }