Milestone 1 code for review -- messages 0 - 7 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confluent.Kafka only non-Microsoft dependency
Still have questions about batches, left it empty for now
minus batch, and hash byte[] printing incorrectly -- values of byte array seem to be correct, just need to convert to hex
preping for post 0 messages -- postfix is hash of key
Not sure yet how to get encoded value out to set msg0.Value
Users/myale/add block impl for messages 0,1,2,3
Need to verify it is what consumer expects
Temporary hardcoding, I think value is calculated somehow based on key
Avro encoding added, plus message4 and code clean up
Message 5 and project cleanup
this will now handle topic keys that are not in the sample doc, as long as they are a single letter Also fix AddDeletesToMessages value to empty byte array Also AddUpdatesToMessages does not send messages for keys not in SchemaMap
GetNonSchemaUpdates to add to message 0 entries that are not part of SchemaMap
batches datatype still needs to be improved
now includes batch message. Need to revisit batches datatype
Add SendBatch parameters, updates to GetUpdatesCountStrings and Deletes/Updates messages
using this in two places and about to put it in a third spot, so refactoring to keep things dry First draft of messages 5 - 7
Users/myale/new batch data type - first draft of messages 5 - 7
Messages all look correct again, using assumption made in slack chat
output of program unchanged
Users/myale/regex and polishing Regex work from yesterday
message0 blocks so it is always first other messages fly out as fast as possible, do not wait for completion
…essagesagain Users/myale/testing cleanup add send message logic back in, message 0 blocks to make sure it is always first
VhatAmI
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.