Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove qubits from SynchronizeOp #322

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Conversation

bcdonovan
Copy link
Contributor

Remove qubit arguments from qcs.syncronize when converting to pulse.

@bcdonovan bcdonovan added the no-reno Disable checking for a releasenote label Apr 17, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

lib/Conversion/QUIRToPulse/QUIRToPulse.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@mbhealy mbhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

Copy link
Contributor

@mbhealy mbhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Still marked 'Draft'

@bcdonovan bcdonovan marked this pull request as ready for review April 23, 2024 23:03
@bcdonovan bcdonovan requested a review from a team as a code owner April 23, 2024 23:03
mbhealy
mbhealy previously approved these changes Apr 24, 2024
Copy link
Contributor

@mbhealy mbhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@reza-j reza-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcdonovan bcdonovan merged commit 9613280 into openqasm:main Apr 25, 2024
3 checks passed
bcdonovan added a commit to bcdonovan/qe-compiler that referenced this pull request Apr 26, 2024
Remove qubit arguments from qcs.syncronize when converting to pulse.
bcdonovan added a commit that referenced this pull request May 2, 2024
Backports:

* af612a2  Fix default-only switch statements (#324)
* 9613280 remove qubits from SynchronizeOp (#322)

---------

Co-authored-by: mbhealy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-reno Disable checking for a releasenote
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants