Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search upward for parameters #320

Merged
merged 6 commits into from
Apr 16, 2024
Merged

search upward for parameters #320

merged 6 commits into from
Apr 16, 2024

Conversation

bcdonovan
Copy link
Contributor

This PR adjusts the ParameterInitialValueAnalysis so that it will search the current module for parameter definitions and then search parent modules if parameters are not found.

@bcdonovan bcdonovan added the no-reno Disable checking for a releasenote label Apr 11, 2024
@bcdonovan bcdonovan marked this pull request as ready for review April 11, 2024 23:31
@bcdonovan bcdonovan requested a review from a team as a code owner April 11, 2024 23:31
@mbhealy
Copy link
Contributor

mbhealy commented Apr 12, 2024

There doesn't appear to be an existing test that calls this pass directly. Do we have some test that exercises this code? If not can we add one in this repo?

kitbarton
kitbarton previously approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@kitbarton kitbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I agree with @mbhealy it would be good to have a test case, if it's easy to do.

@bcdonovan
Copy link
Contributor Author

Added a test with: 48af563

github-actions[bot]
github-actions bot reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

lib/Dialect/QCS/Utils/ParameterInitialValueAnalysis.cpp Show resolved Hide resolved
mbhealy
mbhealy approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@mbhealy mbhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reza-j
reza-j approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@reza-j reza-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcdonovan bcdonovan merged commit 8e7bfd9 into openqasm:main Apr 16, 2024
3 checks passed
@bcdonovan bcdonovan deleted the bd-update-piv-search branch April 16, 2024 15:22
bcdonovan added a commit to bcdonovan/qe-compiler that referenced this pull request Apr 16, 2024
@bcdonovan
search upward for parameters (openqasm#320)
d851f24 
Adjust the ParameterInitialValueAnalysis so that it will search
the current module for parameter definitions and then search parent
modules if parameters are not found.
bcdonovan added a commit that referenced this pull request Apr 16, 2024
@bcdonovan
[Backport] search upward for parameters (#320) (#321)
f791a97 
Adjust the ParameterInitialValueAnalysis so that it will search the
current module for parameter definitions and then search parent modules
if parameters are not found.

Cherry-pick to test_1 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@reza-j reza-j reza-j approved these changes

@mbhealy mbhealy mbhealy approved these changes

@kitbarton kitbarton Awaiting requested review from kitbarton

Assignees
No one assigned
Labels
no-reno Disable checking for a releasenote
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcdonovan @mbhealy @kitbarton @reza-j