Scheduling based on mix frames #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
taalexander
requested changes
Mar 26, 2024
Comment on lines
119
to
120
| std::unordered_set<uint> mixFramesBlockIds = | ||
| getMixFramesBlockIds(quantumGateCallSequenceOp); |
There was a problem hiding this comment.
What is a mix frame block id?
There was a problem hiding this comment.
What is a mix frame block id?
it's the block argument number of the corresponding mix frame
this function returns an unordered set of block argument numbers of the mix frames of a quantum gate; here block refers to the current block that includes the quantum gate call sequence op; I added comment and modified the names in 21961bb; please let me know what you think
Comment on lines
182
to
184
| if (mixFrameToNextAvailabilityMap.find(id) != | ||
| mixFrameToNextAvailabilityMap.end()) { | ||
| if (mixFrameToNextAvailabilityMap[id] < nextAvailableTimeOfAllMixFrames) |
There was a problem hiding this comment.
It seems like this condition can be combined into a single boolean and if? (can use an intermediary value)
There was a problem hiding this comment.
combined into a single boolean in 21961bb
kitbarton
previously approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces scheduling of a quantum circuit based on mix frames in order to reduce the overall duration of the scheduled pulse sequence.