Optimize greedy rewrite passes #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbhealy
previously approved these changes
Mar 15, 2024
Comment on lines
+104
to
+106
| config.strictMode = mlir::GreedyRewriteStrictness::ExistingOps; | ||
| // Each operation can only be modified once so limit | ||
| config.maxIterations = 1; |
There was a problem hiding this comment.
Of these two changes, which provides more benefit? I'm surprised that the first changes things at all since the rewrite pattern isn't adding any new operations.
There was a problem hiding this comment.
I think its maxIterations
taalexander
force-pushed
the
optimize-greedy-rewrites
branch
from
bee5330
to
be9f222
Compare
taalexander
added a commit
to taalexander/qe-compiler
that referenced
this pull request
Mar 15, 2024
Optimize a number of greedy rewrite passes. - QUIRAngleConversionPass: Goes from about ~7.5s for 100x100 to 0.9s on my machine
taalexander
added a commit
that referenced
this pull request
Mar 16, 2024
Optimize a number of greedy rewrite passes. - QUIRAngleConversionPass: Goes from about ~7.5s for 100x100 to 0.9s on my machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize a number of greedy rewrite passes.