Extract Circuits Performance Improvement #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taalexander
requested changes
Mar 12, 2024
There was a problem hiding this comment.
This change looks good to me! I also found it necessary to update the way the circuit operations are being walked on my machine in bcdonovan#1. With this I get performance of
0.0676 ( 0.1%) 0.0676 ( 0.4%) Extract Circuits Pass
without this it was closer to 1 min 50s.
for 100x100x1 circuits.
Update operation walking to be more efficient.
kitbarton
previously approved these changes
Mar 12, 2024
taalexander
approved these changes
Mar 13, 2024
bcdonovan
added a commit
to bcdonovan/qe-compiler
that referenced
this pull request
Mar 13, 2024
This PR improves the performance of the ExtractCircuitsPass by replacing `insertArguments` with `getBody().addArugment`. Also fixes a bug by inserting call_circuit after location of last operation in circuit rather than the first. --------- Co-authored-by: Thomas Alexander <[email protected]>
bcdonovan
added a commit
that referenced
this pull request
Mar 13, 2024
This PR improves the performance of the ExtractCircuitsPass by replacing `insertArguments` with `getBody().addArugment`. Also fixes a bug by inserting call_circuit after location of last operation in circuit rather than the first. --------- Co-authored-by: Thomas Alexander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of the ExtractCircuitsPass by replacing
insertArgumentswithgetBody().addArugment.Also fixes a bug by inserting call_circuit after location of last operation in circuit rather than the first.