Add ExtractCircuitsPass #284
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Needs a merge with main. Reviewing now. |
| using namespace mlir; | ||
| using namespace mlir::quir; | ||
|
|
||
| namespace { |
There was a problem hiding this comment.
LLVM style recommends anonymous namespaces only for class definitions and to use static for objects and functions. This localizes the information to where in the file it is useful to quickly understand while reading the code and reduces indentation overall generally (though I know you haven't indented here).
| currentOp = currentOp->getNextNode()->getNextNode(); | ||
| } | ||
|
|
||
| while (currentOp) { |
There was a problem hiding this comment.
I think a few comments in the body of this loop would help in understanding the flow.
There was a problem hiding this comment.
Added comments with 41febe7.
Also removed special handling of qcs.DelayCycleOp and verified test case binary output vs without circuits.
Co-authored-by: mbhealy <[email protected]>
Co-authored-by: mbhealy <[email protected]>
Co-authored-by: mbhealy <[email protected]>
Co-authored-by: mbhealy <[email protected]>
Co-authored-by: mbhealy <[email protected]>
Co-authored-by: mbhealy <[email protected]>
|
@mbhealy This should be ready for your re-review. |
| // control flow found, no next quantum op | ||
| return std::nullopt; | ||
| } | ||
| if (isa<qcs::ParallelControlFlowOp>(nextOp)) |
There was a problem hiding this comment.
don't we need a case here for if/else ops as well?
There was a problem hiding this comment.
Here we do not as they are covered but the RegionBranchOpInterface
|
|
||
| // if firstQuantumOp is still set then there is an in progress circuit to be | ||
| // ended | ||
| if (firstQuantumOp) { |
There was a problem hiding this comment.
does this condition ever true? because line 281 set firstQuantumOp = nullptr
There was a problem hiding this comment.
Yes you are right, I removed with d6b699b.
Co-authored-by: reza-j <[email protected]>
This PR adds a new ExtractCircuitsPass. This pass will walk the main function and extract quantum operations into `quir.circuit`s. It is intended to be run after all reordering and merging has been completed. The pass currently requires --enable-circuits=true in order to have effect. Circuit formation during QUIRGen has been deprecated. This form of circuit generation is now controlled by the --enable-circuits-from-qasm command line option. --------- Co-authored-by: mbhealy <[email protected]> Co-authored-by: reza-j <[email protected]>
This PR adds a new ExtractCircuitsPass. This pass will walk the main function and extract quantum operations into `quir.circuit`s. It is intended to be run after all reordering and merging has been completed. The pass currently requires --enable-circuits=true in order to have effect. Circuit formation during QUIRGen has been deprecated. This form of circuit generation is now controlled by the --enable-circuits-from-qasm command line option. --------- Co-authored-by: mbhealy <[email protected]> Co-authored-by: reza-j <[email protected]>
This PR adds a new ExtractCircuitsPass. This pass will walk the main function and extract quantum operations into
quir.circuits. It is intended to be run after all reordering and merging has been completed. The pass currently requires--enable-circuits=truein order to have effect.Circuit formation during QUIRGen has been deprecated. This form of circuit generation is now controlled by the --enable-circuits-from-qasm command line option.