Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulse python bindings squash #276

Merged
merged 20 commits into from
Mar 8, 2024
Merged

Pulse python bindings squash #276

merged 20 commits into from
Mar 8, 2024

Conversation

mbhealy
Copy link
Contributor

@mbhealy mbhealy commented Feb 29, 2024

This is a squash of #264 to make the CLA gods happy.

Almost ready for final review.

@mbhealy mbhealy requested a review from a team as a code owner February 29, 2024 15:30
@mbhealy
Copy link
Contributor Author

mbhealy commented Feb 29, 2024

Ready for final review

bcdonovan
bcdonovan requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@bcdonovan bcdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for doing all of the cleanup work hand dealing with all of the boiler plate. A few suggestions but otherwise looks very good to me.

lib/Bindings/Python/DialectOQ3.cpp Show resolved Hide resolved
lib/Bindings/Python/DialectOQ3.cpp Outdated Show resolved Hide resolved
lib/Bindings/Python/DialectQCS.cpp Outdated Show resolved Hide resolved
lib/Bindings/Python/DialectQCS.cpp Outdated Show resolved Hide resolved
lib/Bindings/Python/qcs.h Outdated Show resolved Hide resolved
python_lib/qss_compiler/mlir/dialects/OQ3.td Outdated Show resolved Hide resolved
python_lib/qss_compiler/mlir/dialects/_pulse_ops_ext.py Outdated Show resolved Hide resolved
python_lib/qss_compiler/mlir/dialects/_pulse_ops_ext.py Outdated Show resolved Hide resolved
python_lib/qss_compiler/mlir/dialects/_quir_ops_ext.py Outdated Show resolved Hide resolved
test/python_lib/test_python_bindings.py Show resolved Hide resolved
kitbarton
kitbarton previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@kitbarton kitbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brian had several good comments.
Aside from those, this LGTM.

@mbhealy mbhealy mentioned this pull request Mar 7, 2024
Closed
@mbhealy
Copy link
Contributor Author

mbhealy commented Mar 7, 2024

Thanks for the extensive review @bcdonovan!

@mbhealy
Copy link
Contributor Author

mbhealy commented Mar 7, 2024

@bcdonovan ready for second round.

bcdonovan
bcdonovan approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@bcdonovan bcdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you for getting this across the finish line and doing all of the clean up for the prior authors.

@mbhealy mbhealy merged commit 328a373 into openqasm:main Mar 8, 2024
3 checks passed
@mbhealy
Copy link
Contributor Author

mbhealy commented Mar 8, 2024

Many thanks to @bcdonovan for starting this project and to @JLou7 for pushing this through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SooluThomas SooluThomas SooluThomas left review comments

@bcdonovan bcdonovan bcdonovan approved these changes

@kitbarton kitbarton kitbarton left review comments

@taalexander taalexander Awaiting requested review from taalexander

@reza-j reza-j Awaiting requested review from reza-j

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbhealy @bcdonovan @SooluThomas @kitbarton