Replaces the uses of quir call with the converted pulse call in QuirToPulse

[reza-j]

This PR replaces all the uses of quir circuits with their corresponding pulse call, which is needed for dynamic circuits when we want to make a decision based on the measurement result.

The PR also copies over the quir attributes of measure op to their corresponding pulse call.

[kitbarton]

This is one thing that confuses me about MLIR operations. The callCircuitOp and moduleOp are not explicitly passed by reference, but the mainFunc is.
Do you know if these are still being passed by reference, or if this is going to pass by value? Pass by value will create copies, which is inefficient. It is better to pass by reference and mark as const to indicate they will not be changed.

[reza-j]

I tested this today. There might be a better way to do this, but what I did was trying to print the memory location of variables before calling the function and inside the function with:

std::cout << &callCircuitOp << "\n"
std::cout << &moduleOp << "\n"

case1: function arguments are (mlir::quir::CallCircuitOp callCircuitOp, mlir::func::FuncOp &mainFunc, ModuleOp moduleOp)

case2: function arguments are (mlir::quir::CallCircuitOp &callCircuitOp, mlir::func::FuncOp &mainFunc, ModuleOp &moduleOp)

I noticed that in case1, the memory addresses were different before calling the function and inside the function, so my guess is that it copies in that case. While for case2, memory addressed were the same

given this, I added changes to have & in function args

[reza-j]

not sure if this is one of the cases where we can use const. I tried e.g., const mlir::quir::CallCircuitOp &callCircuitOp and got a compile error saying

error: 'this' argument to member function 'getOperand' has type 'const mlir::quir::CallCircuitOp', 
but function is not marked const
          auto durOpConstantOp = callCircuitOp.getOperand(argNum)

[kitbarton]

Yes, I see. MLIR seems to be missing a lot of const versions of the methods. I can see this would be painful to try and figure out what can be const as a result.
I think this is ok, we just need to be mindful that any changes that are made to the op now will persist (there shouldn't be any, but need to keep it in mind).

[kitbarton]

LGTM.
Thank you for changing the parameters to pass-by-reference.