add support for pulse waveform container op #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
bcdonovan
approved these changes
Aug 2, 2023
include/Dialect/Pulse/IR/PulseOps.td
Outdated
| let verifier = [{ return ::mlir::pulse::verify(*this); }]; | ||
| } | ||
|
|
||
| def Pulse_TerminatorOp : Pulse_Op<"terminator", [NoSideEffect, Terminator]>{ |
There was a problem hiding this comment.
You could label the Pulse_WaveformContainerOp with NoTerminator and then the terminator would not be required. Since this is just a container and not intended for lowering I think that would be reasonable.
See this for details.
There was a problem hiding this comment.
oh cool! addressed in f409108
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new pulse operation, pulse.waveform_container, which can be used to contain a number of pulse waveforms.