Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check in PPOExperiment to avoid unintended behaviors. #16

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

garrett4wade
Copy link
Contributor

@garrett4wade garrett4wade commented Jul 3, 2024

#14 Since CUDA graph requires pinned parameter/input/output memory, it is not compatible with parameter reallocation.

Add a check in PPOExperiment to avoid unintended behaviors.

@garrett4wade garrett4wade merged commit 6caa522 into main Jul 3, 2024
2 checks passed
@garrett4wade garrett4wade deleted the ppo-cudagraph branch July 4, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant