-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase time resources #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think these methods might finish if they get twice the amount of time ? Otherwise all it'll do is make the benchmark take longer to finish without any extra results 😅
Hard to say but 4 hours isn't a lot of time for biggish datasets. I'm pretty sure at lease scanorama should work. I think it will help for at least some of them. |
Alright, makes sense. If we bump the time limits for some components, I think we should bump it for all methods to ensure that the different methods get a level playing field when new datasets get added |
So I should set |
I'd sure the same time label across all methods -- it's a bit unfair if we don't |
Describe your changes
Increase allocated time for methods failing for 143 exit codes
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!