Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new website design #9

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mariangz
Copy link

This PR includes a redesign of the website, changes in the hierarchy and an update of the content.

screencapture-file-Users-mariano-Documents-programming-nh-openpgpjs-web-2023-index-html-2023-12-21-16_29_57

@twiss
Copy link
Member

twiss commented Jan 4, 2024

Hey 👋 Thanks!

This mostly looks good, just the diagram sticks out a bit like a sore thumb now. I've sketched an updated and somewhat simplified diagram here: https://excalidraw.com/#json=mFhLNtBc5Tkj0FBtNxCpj,b-SJdV_0YS3wF7t5L-OgJw. If you have time, could you replace it with that?

And then, perhaps to match, we could add some text saying e.g. "To fetch public keys, the WKD client and/or HKP client can be used. The latter can also be used to upload public keys to OpenPGP key servers."

@mariangz
Copy link
Author

mariangz commented Jan 8, 2024

Hi @twiss ! :)

What do you think now?

Screenshot 2024-01-08 at 12 25 58

@twiss
Copy link
Member

twiss commented Jan 8, 2024

Thanks! This is becoming increasingly nitpicky but maybe we can have a border in the style of the diagram, rather than the blue border, e.g. something like: https://excalidraw.com/#json=oyM2fcSJUCRCGn4ZN-pRh,7ZA_BcNRDNRAGna_SUyU9g

@AlexanderWillner
Copy link
Member

Thanks a lot! Interesting: it has been 13(!) years that I created the original image...time flies...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants