Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the code style libraries #1842

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Update of the code style libraries #1842

merged 3 commits into from
Oct 18, 2023

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Oct 18, 2023

Perform a synchronous update of the code style libraries, to avoid the circular update dependencies blocking #1794, #1795, #1796.
Change code as required by the new coding style requirements.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1842 (d0d56b6) into master (bcf3855) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #1842   +/-   ##
=======================================
  Coverage   77.73%   77.73%           
=======================================
  Files         127      127           
  Lines        5268     5268           
=======================================
  Hits         4095     4095           
  Misses       1173     1173           
Flag Coverage Δ
unittests 77.73% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pyramid_oereb/core/config.py 80.99% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@voisardf voisardf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested the upgrades locally, but code looks fine to me, thanks.

@jwkaltz jwkaltz merged commit 86c166e into master Oct 18, 2023
10 of 11 checks passed
@jwkaltz jwkaltz deleted the codestyle_deps branch October 18, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants