Address review comments

openoereb · Aug 13, 2024 · 62c466f · 62c466f
1 parent bced4b5
commit 62c466f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/dev/config/pyramid_oereb.yml.mako b/dev/config/pyramid_oereb.yml.mako
@@ -246,6 +246,7 @@ pyramid_oereb:
         fr: https://wms.geo.admin.ch/?SERVICE=WMS&REQUEST=GetMap&VERSION=1.3.0&STYLES=default&CRS=EPSG:2056&BBOX=2475000,1065000,2850000,1300000&WIDTH=493&HEIGHT=280&FORMAT=image/png&LAYERS=ch.swisstopo-vd.amtliche-vermessung
       layer_index: 0
       layer_opacity: 1.0
+      # Option to check certificate for external WMS. Default and recommended setting: True
       verify_certificate: True
     visualisation:
       method: pyramid_oereb.core.hook_methods.produce_sld_content

diff --git a/pyramid_oereb/contrib/data_sources/standard/models/__init__.py b/pyramid_oereb/contrib/data_sources/standard/models/__init__.py
@@ -175,15 +175,13 @@ class ViewService(base):
                 representation (multilingual).
             layer_index (int): Index for sorting the layering of the view services for a theme
             layer_opacity (float): Opacity of a view servicA
-            verify_certificate (boolean): Whether the certificate of the WMS shall be verified
         """
         __table_args__ = {'schema': schema_name}
         __tablename__ = 'view_service'
         id = Column(pk_type, primary_key=True, autoincrement=False)
         reference_wms = Column(JSONType, nullable=False)
         layer_index = Column(Integer, nullable=False)
         layer_opacity = Column(Float, nullable=False)
-        verify_certificate = Column(Boolean, nullable=True)
 
     return ViewService
 

diff --git a/pyramid_oereb/contrib/data_sources/standard/sources/plr.py b/pyramid_oereb/contrib/data_sources/standard/sources/plr.py
@@ -163,7 +163,8 @@ def from_db_to_view_service_record(self, view_service_from_db, legend_entry_reco
             Config.get('srid'),
             Config.get('proxies'),
             legends=legend_entry_records,
-            verify_certificate=view_service_from_db.verify_certificate
+            # Note: our standard database model does not contain an option to override the verify_certificate
+            verify_certificate=True
         )
         return view_service_record