Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare): cloudflare-streaming do not use the edge runtime #644

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 25, 2024

Discussed at #642 (comment)
I'll add the validation in a follow-up PR

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: d381220

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb requested a review from conico974 November 25, 2024 08:45
Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@644

commit: d381220

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.02% 1659 / 7533
🔵 Statements 22.02% 1659 / 7533
🔵 Functions 56.25% 99 / 176
🔵 Branches 70.28% 414 / 589
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/core/requestHandler.ts 0% 0% 0% 0% 1-239
packages/open-next/src/core/routingHandler.ts 0% 0% 0% 0% 1-243
packages/open-next/src/core/routing/middleware.ts 96.89% 85.29% 50% 96.89% 34-37, 120
packages/open-next/src/overrides/converters/aws-cloudfront.ts 77.45% 80.76% 100% 77.45% 105-108, 153-193
packages/open-next/src/overrides/wrappers/aws-lambda-streaming.ts 0% 0% 0% 0% 1-122
packages/open-next/src/overrides/wrappers/cloudflare-streaming.ts 0% 0% 0% 0% 1-72
packages/open-next/src/overrides/wrappers/cloudflare.ts 0% 100% 100% 0% 6-68
packages/open-next/src/overrides/wrappers/dummy.ts 0% 100% 100% 0% 3-9
packages/open-next/src/overrides/wrappers/node.ts 0% 0% 0% 0% 1-69
Generated in workflow #778 for commit d381220 by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little comment, but other than that LGTM

};
} satisfies Wrapper<
InternalEvent,
InternalResult | ({ type: "middleware" } & MiddlewareOutputEvent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add type:middleware to the MiddlewareOutputEvent directly

@vicb
Copy link
Contributor Author

vicb commented Nov 25, 2024

@conico974 PTAL, I have tried to clarify the types

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks
Good idea to add the satisfies, it will be a lot safer now

@vicb vicb merged commit f685dde into main Nov 25, 2024
3 checks passed
@vicb vicb deleted the edge branch November 25, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants