-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudflare): cloudflare-streaming do not use the edge runtime #644
Conversation
🦋 Changeset detectedLatest commit: d381220 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little comment, but other than that LGTM
}; | ||
} satisfies Wrapper< | ||
InternalEvent, | ||
InternalResult | ({ type: "middleware" } & MiddlewareOutputEvent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add type:middleware
to the MiddlewareOutputEvent
directly
@conico974 PTAL, I have tried to clarify the types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks
Good idea to add the satisfies
, it will be a lot safer now
Discussed at #642 (comment)
I'll add the validation in a follow-up PR