Update NADC Library to Python 3 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added VS ignore
…d data to actual folder.
…6, dedupe and upload to DB
…upe need finished.
|
👍 Looks like progress to me. I'm no lawyer, so in the absence of a LICENSE file, I don't know what the implications of adding one are. I'll try to find time this week to run stuff under Python3 and see what happens for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Library to use Python 3. Dropped dependency on fabric. I created a lib module and broke out the fabfile.py into parser functions, which are called from main.py. There is parser class and utils class, in the utils class, the dedupe_entities function is extremely slow, mainly because the sheer amount of records. Look for Roadmap in the readme to see what it is left to get proper pipe delimited files to upload into a database.