Hexagons #13
Open
Hexagons #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PtrMan
commented
Nov 21, 2018
PtrMan
commented
- mapping of hexagons
- rendering of hexagons
|
The position of the predictions is a bit of - but fine for now |
patham9
requested changes
Nov 22, 2018
There was a problem hiding this comment.
Hm. Benefit of hexagon is that it allows more direction-related precision (6 directions to a direct neighbour instead of 4). Rendering them is however more expensive (it can't be drawn by just 1 line per vertical and horizontal position or something analogical, each hexagon needs to draw 6 invidiual edges instead), is this the reason why it runs slower on my machine? And a bigger issue: this PR doesn't get the positioning right yet.
|
Great job! Although at this point we probably don't have reason to merge it, in case that we want to go for hexagons in the future, this will be the way to go, don't remove the branch/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.