-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working Cycle Metric #87
Merged
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2276950
Add simple time calculation for 1 working cycle
ccrock4t 624dee0
store cycle metrics in reasoner; calculate cycles per second
ccrock4t 545ab03
Add a ConsolePlus command to display cycles per second ("/cycles")
ccrock4t 799b9d9
Extend metric output on ConsolePlus. Update comments; remove whitespace.
ccrock4t 2b2fd70
Update Reasoner.py
ccrock4t 83e8275
keep a running average of cycle duration
ccrock4t 7c7b8c4
Move function to bottom of file, since it will rarely be touched comp…
ccrock4t eec912c
calculate running mean of cycle duration
maxeeem 3f231d7
Merge pull request #105 from bowen-xu/running-mean
ccrock4t f0a41d4
Revert config
ccrock4t c2ca107
Merge branch 'working_cycle_time_metric' of https://github.com/bowen-…
ccrock4t File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to keep a fixed window instead of continuously calculated average?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was the variables could overflow if we don't set an upper limit to the sum/ cycles count. For example in this code the
cycles_count
is never capped. But I guess in practice NARS would never run for enough cycles to overflow, and it seems Python is also special in that it will infinitely extend integers so they never overflowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, really? That's cool, do you have a link? just for my own education ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found it on stack overflow: https://stackoverflow.com/questions/52151647/integer-overflow-in-python3
Which references this doc: https://docs.python.org/3/c-api/long.html#integer-objects