Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add judgment dot to report #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add judgment dot to report #21

wants to merge 1 commit into from

Conversation

PtrMan
Copy link
Contributor

@PtrMan PtrMan commented Sep 22, 2019

No description provided.

TonyLo1
TonyLo1 requested changes Sep 22, 2019
View reviewed changes
Copy link
Member

@TonyLo1 TonyLo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this approach. What I suggest is to generalise displayAnswer further and rename to displayResponse. The response message should be formatted at the source not in displayAnswer. If you take the suggested approach this can also be use fror Quests and other TBD response types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyLo1 TonyLo1 TonyLo1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PtrMan @TonyLo1