OCLOMRS-1094: Use concept url when removing concept from collection #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suruchee
reviewed
Mar 23, 2022
There was a problem hiding this comment.
Thanks @Piumal1999 for the PR, but we still cannot delete the already existing concepts so let's discuss in squad call to merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA TICKET NAME:
Unable to delete concept from collection with OCL Platform 2.0.117+
Summary:
Removing a concept within a dictionary (collection) in the Dictionary Manager visually removes the concept, but the concept isn't actually deleted from the collection within OCL and refreshing the page reveals the bug as the concept "reappears" within the dictionary.
As @bmamlin suggested here, I updated the delete request body.
Preview:
Screen.Recording.2022-03-22.at.23.54.48.mov