catch npe

openmrs · Dec 31, 2023 · 20dc52d · 20dc52d
1 parent 8ab2b7e
commit 20dc52d
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/omod/src/main/java/org/openmrs/web/controller/report/CohortReportFormController.java b/omod/src/main/java/org/openmrs/web/controller/report/CohortReportFormController.java
@@ -391,14 +391,17 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
 	}
 
 	private Node findChild(Node parent, String name) {
-		if (parent != null) {
-			NodeList list = parent.getChildNodes();
-			for (int i = 0; i < list.getLength(); ++i) {
-				Node node = list.item(i);
-				if (node.getNodeName().equals(name))
-					return node;
-			}
+		if (parent == null) {
+			return null;
+		}
+
+		NodeList list = parent.getChildNodes();
+		for (int i = 0; i < list.getLength(); ++i) {
+			Node node = list.item(i);
+			if (node.getNodeName().equals(name))
+				return node;
 		}
+
 		return null;
 	}