(feat) Include column definition within the dataset evaluation context #245
Conversation
| @@ -90,6 +90,7 @@ public DataSet evaluate(DataSetDefinition dataSetDefinition, EvaluationContext c | |||
| StopWatch sw = new StopWatch(); | |||
| sw.start(); | |||
|
|
|||
| ec.addContextValue("columnDefinitions", cd); | |||
There was a problem hiding this comment.
Can you describe why this is needed? Is there a ticket for this change? What problem are you trying to solve?
There was a problem hiding this comment.
This was needed within the sequence of an issue identified on patient-grid. The patient-grid uses module-reporting to retrieve data for populating the grid. An issue arises when the same concept is reused within a single form. patient-grid lacks sufficient data to correlate observations with their respective columns.
On patient-grid, module-reporting DataSetDefinitionServiceImpl is invoked here and, on the 1st arg, column data is passed. Foreach column, reporting-module invokes patient-grid's ObsForLatestEncounterPatientDataEvaluator.evaluate. However, the challenge here is that there is no provided data that allows us to identify the specific column being processed. Currently, fetching observations relies solely on encounter and concept, which can lead to multiple matching observations, differing only in their formNamespaceAndPath.
The inclusion of column data within the ObsForLatestEncounterPatientDataEvaluator.evaluate will allow us to correlate the obs formNamespaceAndPath with the right column.
There was a problem hiding this comment.
Thanks @icrc-psousa . Could you configure things to pass the necessary information as a configuration parameter from your data set definition down to your data definition. Can you show me where these data set and data definitions are constructed and configured?
Just looking at your commit here icrc/openmrs-module-patientgrid@173fde6 it seems that it would help if your data definition could be configured with formNamespaceAndPath in addition to concept and encounterType, and then if this is present you could just match on it directly.
There was a problem hiding this comment.
Data set definition is constructed here. I missed the fact that it's populated on patient-grid side.
We can include the formNamespaceAndPath and other required data, if needed, on patient-grid side here on this data definition as you've suggested. Thanks for your input @mseaton!
This PR on module-reporting won't be needed.
Include column definition within the dataset evaluation context