RA-2037: use mother's info to register a child #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogoodrich
approved these changes
May 31, 2024
There was a problem hiding this comment.
LGTM, I did have one question you will see @cioan but that is really to understand it better and perhaps suggest a more detailed comment. Thanks!
| @@ -137,6 +137,10 @@ fieldset[id\$="-fieldset"] div > div { | |||
| if (NavigatorController.getQuestionById(questionName) != undefined) { | |||
| NavigatorController.getQuestionById(questionName).questionLi.addClass("done"); | |||
| } | |||
| if (fieldName == 'mother-field') { | |||
There was a problem hiding this comment.
I forget, where does this name "mother-field" get set up? Is it something in our config?
There was a problem hiding this comment.
Yes, this field gets configured in our pihcore SL config.
There was a problem hiding this comment.
Got it, thanks @cioan ! I'm struggling with what the exact comment is, but can we add something here noting that this is a rather specific hack for when having a "mother-field" configured?
|
Thanks @mogoodrich ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the person address widget and the relationships widget have onBlur() and onChange() events that get trigger automatically every time the form is displayed, I had to workaround those limitations when the mother info is included in the registration form. Thanks @mogoodrich for reviewing it!