Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-3723 - bed management - flatten beds array before filtering by occupancy status #1388

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

amosmachora
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR adds a simple fix to flatten the bed's array before filtering the elements inside it. The issue was because previously we were running a filter on an array of arrays which made the callback item an array of beds not a bed.

Screenshots

occupancy-status-fix.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-3723

Other

@chibongho chibongho self-requested a review November 27, 2024 14:22
@chibongho chibongho changed the title (fix): flatten beds array before filtering by occupancy status (fix) O3-3723 - bed management - flatten beds array before filtering by occupancy status Nov 27, 2024
Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@mogoodrich
Copy link
Member

Thanks for the review @chibongho ! @amosmachora let us know if you have merge privileges or if you need one of us to merge.

@amosmachora
Copy link
Contributor Author

@mogoodrich I do not have merge privileges.

@chibongho chibongho merged commit c8d3f06 into openmrs:main Nov 27, 2024
6 checks passed
@chibongho
Copy link
Contributor

Ok, I just merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants