(refactor) : bed management modal system #1381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR refactors the current modal functionality in the bed management app to use the openmrs modal system as described here. When I was working on this PR I was careful only to refactor the modals, separate edit-add functionalities (beds, bed tags bed types), and not change any underlying implementation. Any change made can be considered absolutely necessary.
I also improved the UX when submitting the modals by adding loading states on the button and showing a spinner. Nothing major.
Screenshots
Short video verifying that nothing breaks after this change
bed-modals-refactor.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-4199
Other