Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3 2777: Dispensing: Only have Prescription Tabs load when selected #98

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

mogoodrich
Copy link
Member

Interested in others thoughts on this, see: https://openmrs.atlassian.net/browse/O3-2777

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially had questions but the ticket description cleared them out. The all prescriptions tab should eventually be optimized so that it doesn't affect loading. The main focus is however on active prescriptions.

Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mogoodrich - thanks!

@mogoodrich
Copy link
Member Author

Thanks @mseaton @pirupius , merging!

@mogoodrich mogoodrich merged commit ab74fa0 into main Jan 29, 2024
4 checks passed
@mogoodrich mogoodrich deleted the O3-2777 branch January 29, 2024 13:29
donaldkibet added a commit to palladiumkenya/openmrs-esm-dispensing-app that referenced this pull request Feb 22, 2024
* (chore) Migrate to newer transifex version (openmrs#95)

* (chore) Add chinese translations (openmrs#96)

* (chore) Switch to new frontend building job

* O3 2777: Dispensing: Only have Prescription Tabs load when selected (openmrs#98)

* Release v1.3.0 (openmrs#99)

* Deploy kenyaemr esm-dispensing-app package

* Update cicd

* (feat) Integrate dispense with stock inventory initial implementation

* Remove disable for batch number to allow for quantity restriction

* (feat) require payments before dispensing medications

---------

Co-authored-by: ThemboJonathan <[email protected]>
Co-authored-by: Ian <[email protected]>
Co-authored-by: Mark Goodrich <[email protected]>
Co-authored-by: Jayasanka Weerasinghe <[email protected]>
Co-authored-by: jecihjoy <[email protected]>
Co-authored-by: makombe <[email protected]>
donaldkibet pushed a commit to palladiumkenya/openmrs-esm-dispensing-app that referenced this pull request Mar 22, 2024
* (chore) Migrate to newer transifex version (openmrs#95)

* (chore) Add chinese translations (openmrs#96)

* (chore) Switch to new frontend building job

* O3 2777: Dispensing: Only have Prescription Tabs load when selected (openmrs#98)

* Release v1.3.0 (openmrs#99)

* (chore) Loosen fhir2 dependency requirement (openmrs#100)

* (chore) Release v1.3.1 (openmrs#101)

* Update fhir dependancy

---------

Co-authored-by: ThemboJonathan <[email protected]>
Co-authored-by: Ian <[email protected]>
Co-authored-by: Mark Goodrich <[email protected]>
Co-authored-by: Jayasanka Weerasinghe <[email protected]>
Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants