Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging unit in dispensing app #117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gabriel090
Copy link

@gabriel090 gabriel090 commented Aug 20, 2024

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Add packing name in dispensing app.

Screenshots

dispense.mp4

Related Issue

Other

Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm defer to others with stock management module experience about the details, but generally LGTM!

@ojwanganto
Copy link

@gabriel090 - kindly link this to a ticket and provide a screenshot/video for the change.

@@ -72,12 +72,13 @@ const StockDispense: React.FC<StockDispenseProps> = ({ medicationDispense, updat
const toStockDispense = (inventoryItems) => {
return t(
'stockDispenseDetails',
'Batch: {{batchNumber}} - Quantity: {{quantity}} ({{quantityUoM}}) - Expiry: {{expiration}}',
'Batch: {{batchNumber}} - Quantity: {{quantity}} - Expiry: {{expiration}} - Packaging Size: ({{quantityUoM}})-{{quantityFactor}}',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we can use the 'Pack size' short name or just Pack.

@ojwanganto
Copy link

Thanks, @gabriel090. Please add a screenshot and ticket for this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants