(feat) : O3-3686 Add ability to close active visit on medication dispense #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @donaldkibet. I defer to the rest for their reviews |
ojwanganto
reviewed
Aug 2, 2024
mogoodrich
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Generally, LGTM, thanks @donaldkibet !
I didn't dig super-deep into the form handler, but it looks right, we can test.
One thing, it looks like you handled this, but since we can't handle this transactionally (all in one request) it's good to have as helpful error messages as possible, saying exactly what succeeded and what didn't.
| enabled: { | ||
| _type: Type.Boolean, | ||
| _description: | ||
| 'Enables or disables the ending of the current visit upon medication dispensing. When set to true, the system will attempt to end the visit after a successful medication dispense, subject to the conditions specified in the "visitTypes" config.', |
There was a problem hiding this comment.
Minor note, you might want to clarify that this renders a checkbox to close the visit, it doesn't automatically close the visit (if I'm understanding correctly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
see https://openmrs.atlassian.net/browse/O3-3686
Screenshots
Kapture.2024-08-02.at.07.15.31.mp4
Related Issue
Other