Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the billing concepts to add service types ConvSet #857

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

alaboso
Copy link
Contributor

@alaboso alaboso commented Oct 30, 2024

Description of what I changed

This PR Updates the billing concepts to add service types ConvSet

Issue I worked on

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

mvn --batch-mode --update-snapshots --activate-profiles distro,validator clean package

No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@alaboso alaboso requested review from dkayiwa, ODORA0 and ebambo October 30, 2024 21:03
@alaboso alaboso merged commit deef606 into openmrs:main Oct 31, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants