Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(release) Release 3.0.0-beta.21 #816

Merged
merged 2 commits into from
Jun 19, 2024
Merged

(release) Release 3.0.0-beta.21 #816

merged 2 commits into from
Jun 19, 2024

Conversation

vasharma05
Copy link
Member

This PR cuts a new release Beta 21.

This release bumps the following versions:

  1. [email protected]
  2. Rest webservices @ 2.44.0

distro/pom.xml Outdated
<initializer.version>2.7.0-SNAPSHOT</initializer.version>
<webservices.rest.version>2.44.0-SNAPSHOT</webservices.rest.version>
<openmrs.version>2.6.6</openmrs.version>
<initializer.version>2.7.0-20240521.045407-11</initializer.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a non-SNAPSHOT release version of Iniz? Relying on SNAPSHOTs is causing us a lot of pain.

Copy link
Member Author

@vasharma05 vasharma05 Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ibacher!
What will be the version to be used?

This is the latest Snapshot version after the last commit's release job

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

May I change the initializer version 2.6.0?

Copy link
Member

@jayasanka-sack jayasanka-sack Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a non-SNAPSHOT release version of Iniz? Relying on SNAPSHOTs is causing us a lot of pain.

I was thinking the same; it would be a mess to rebuild if those were cleaned up.

There are three other snapshots: Queue, Appointments, and Teleconsultation. I wonder why we reached that conclusion in the last release.

@jayasanka-sack
Copy link
Member

We can safely ignore the following E2E test failures for these reasons:

  1. Patient Management:
    The test is failing due to a small backend change involving the patient details endpoint. Although the test has already been updated, this job is running outdated tests from the time of the frontend module's release. Therefore, we can ignore this failure.

  2. Patient Chart:
    The failure is because the tests were still using the angular form engine, whereas this release uses RFE.

  3. Core:
    There is a minor failure due to an issue with an assertion.

@gracepotma
Copy link
Contributor

gracepotma commented Jun 19, 2024

Can we get a non-SNAPSHOT release version of Iniz? Relying on SNAPSHOTs is causing us a lot of pain.

Agreed @ibacher - but let's do this as a second step. @jayasanka-sack has agreed to follow through on that.
Rationale: Given we've been using SNAPSHOT release versions (apparently?!) up until this moment, it seems unideal to force the SNAPSHOT versions for this urgent change. But 100% agreed lets make that change; huge thanks to Jayasanka for committing to see this through :)

@gracepotma
Copy link
Contributor

Thank you Jaysanka for explaining those test failures!! <3 Very reassuring.

@jayasanka-sack jayasanka-sack merged commit fb60633 into main Jun 19, 2024
3 of 7 checks passed
@ibacher
Copy link
Member

ibacher commented Jun 19, 2024

The concern with Iniz is that about SNAPSHOTs per se. It's that Mekom's Maven instance only keeps a few SNAPSHOTs around, meaning that these releases will break (you can see various messages about people unable to install O3 because the specific SNAPSHOT version we've been relying on no longer exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants