Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1583: Cause of Death concept with sample answers #815

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

gracepotma
Copy link
Contributor

@gracepotma gracepotma commented Jun 11, 2024

Includes the following:
image

Ticket: https://openmrs.atlassian.net/browse/O3-1583

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ibacher ibacher merged commit 073d577 into main Jun 11, 2024
7 checks passed
@ibacher ibacher deleted the gracepotma-causeofdeathconcepts branch June 11, 2024 18:51
@denniskigen
Copy link
Member

It looks like the remaining concern in dev3 is that the causeOfDeath global property doesn't exist @ibacher
@gracepotma:

CleanShot 2024-06-11 at 10  34 27@2x

@gracepotma
Copy link
Contributor Author

gracepotma commented Jun 12, 2024

Was causeOfDeath as a Global Property supposed to somehow be introduced by the metadata...? I'm guessing that's a separate issue?
(Or was there some additional mapping I should do in the metadata?)

@denniskigen
Copy link
Member

No, Grace. I was alluding to it for posterity so I can discuss a fix with Ian later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants