Add bill related visit attributes #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CynthiaKamau
force-pushed
the
billing-visit-attributes
branch
3 times, most recently
from
91af039 to
8fc3e8a
Compare
dkayiwa
reviewed
Mar 14, 2024
| @@ -1,3 +1,9 @@ | |||
| Uuid,Void/Retire,Entity name,Name,Description,Min occurs,Max occurs,Datatype classname,Datatype config,Preferred handler classname,Handler config,_order:1000 | |||
| 57ea0cbb-064f-4d09-8cf4-e8228700491c,,Visit,Punctuality,,0,1,org.openmrs.customdatatype.datatype.ConceptDatatype,d81d4698-e78c-420d-aac5-cb1f606fb32e,,, | |||
| aac48226-d143-4274-80e0-264db4e368ee,,Visit,Insurance Policy Number,,0,1,org.openmrs.customdatatype.datatype.FreeTextDatatype,,,, | |||
| 3a988e33-a6c0-4b76-b924-01abb998944b,,Visit,Insurance Scheme,The insurance scheme the patient is using to settle payment for services,0,1,org.openmrs.customdatatype.datatype.FreeTextDatatype,,,, | |||
| 8553afa0-bdb9-4d3c-8a98-05fa9350aa85,,Visit,Payment Method,The payment method used by the patient to settle payment,0,1,org.openmrs.customdatatype.datatype.FreeTextDatatype,,,, | |||
There was a problem hiding this comment.
I see that they are free text. But what kind of values do these attribute types take? Names, Uuids, List of constants? Giving examples in the description makes it super clear. :)
There was a problem hiding this comment.
Expected values are uuids
There was a problem hiding this comment.
It greatly helps if the description includes that because when i saw this, i had no idea whether this expected a uuid, name, or something else.
CynthiaKamau
force-pushed
the
billing-visit-attributes
branch
from
8fc3e8a to
830a8a8
Compare
CynthiaKamau
force-pushed
the
billing-visit-attributes
branch
from
830a8a8 to
1090736
Compare
dkayiwa
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.