Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-2204: Add and configure demo queues to the refapp #789

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Conversation

mseaton
Copy link
Member

@mseaton mseaton commented Mar 13, 2024

This PR tags the "Outpatient Clinic" as a "Queue Location", adds 2 demo queues (one for each of the configured services of "Triage" and "Consultation") associated with this Location, and configures the necessary Queue global properties to reflect the installed Concepts. Note: This requires a SNAPSHOT version of initializer to install queues, it would be good if we can get that released @ibacher, ideally with my change to the OclLoader, but I don't see that as necessary to merge this PR.

With this change, one will be able to use the service queues esm in the refapp demo / dev3.

…ode a uuid so that a match will be detected if already installed.
@mseaton
Copy link
Member Author

mseaton commented Mar 15, 2024

Ping on this? @gracepotma / @ibacher ?

Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gracepotma
Copy link
Contributor

What would this mean for implementations who do not use Iniz? Do they end up in a weird state?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry what changed here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a column

<!-- https://app.openconceptlab.org/#/orgs/openmrs/sources/DemoQueueConcepts/concepts/DemoQueue-Status/ -->
<globalProperty>
<property>queue.statusConceptSetName</property>
<value>d60ffa60-fca6-4c60-aea9-a79469ae65c7</value> <!-- PIH Queue Status Set -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably get rid of the comment mentioning PIH here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch - removed @ibacher

@ibacher
Copy link
Member

ibacher commented Mar 21, 2024

What would this mean for implementations who do not use Iniz?

It's just global properties and concept sets, so they'd need to load those in some other fashion.

@ibacher ibacher changed the title O3-2204 - Add and configure demo queues to the refapp (feat) O3-2204: Add and configure demo queues to the refapp Mar 22, 2024
@ibacher ibacher merged commit 95c8a5e into main Mar 22, 2024
7 checks passed
@ibacher ibacher deleted the O3-2204 branch March 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants